[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/16] Change variable name to be more specific to avoid confusion



On Tue, Apr 02, 2013 at 06:11:26PM -0400, Dan Walsh wrote:
> Signed-off-by: Dan Walsh <dwalsh redhat com>
> ---
>  bin/virt-sandbox-service | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service
> index ca472f5..f32fd4a 100755
> --- a/bin/virt-sandbox-service
> +++ b/bin/virt-sandbox-service
> @@ -551,13 +551,13 @@ PrivateNetwork=false
>              raise OSError(_("Failed to mount image %s on %s") %  (self.image, self.dest))
>  
>      def save_config(self):
> -        config = self.get_config_path()
> -        if os.path.exists(config):
> -            os.remove(config)
> -        self.config.save_to_path(config)
> +        config_path = self.get_config_path()
> +        if os.path.exists(config_path):
> +            os.remove(config_path)
> +        self.config.save_to_path(config_path)
>          if selinux is not None:
> -            selinux.restorecon(config)
> -        sys.stdout.write(_("Created sandbox config %s\n") % config)
> +            selinux.restorecon(config_path)
> +        sys.stdout.write(_("Created sandbox config %s\n") % config_path)
>  
>      def _get_image_path(self):
>              mounts = self.config.get_mounts()

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]