[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [sandbox PATCH 01/15] virt-sandbox-service-util needs to free allocated memory.



Coverity found that we could be leaking memory with virt-sandbox-service-util -e
---
 bin/virt-sandbox-service-util.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/bin/virt-sandbox-service-util.c b/bin/virt-sandbox-service-util.c
index 4d164d8..a292fcd 100644
--- a/bin/virt-sandbox-service-util.c
+++ b/bin/virt-sandbox-service-util.c
@@ -194,8 +194,9 @@ static int set_process_label(pid_t pid) {
 static int container_execute( GVirSandboxContext *ctx, const gchar *command, pid_t pid ) {
 
     int ret = EXIT_FAILURE;
-    char **argv;
-    int argc;
+    char **argv = NULL;
+    int argc=-1;
+    int i;
 
     if (set_process_label(pid) < 0)
         goto cleanup;
@@ -227,6 +228,10 @@ static int container_execute( GVirSandboxContext *ctx, const gchar *command, pid
     }
 
 cleanup:
+    for (i = argc; i >= 0; i--)
+            free(argv[i]);
+    free(argv);
+
     return ret;
 }
 
-- 
1.8.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]