[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: Fix volume cloning for logical volume.



On 04/04/2013 07:15 AM, Atsushi Kumagai wrote:
> When creating a logical volume with virStorageVolCreateXMLFrom,
> "qemu-img convert" is called internally if clonevol is a file volume.
> Then, vol->target.format is used as output_fmt parameter but the 
> target.format of logical volumes is always 0 because logical volumes 
> haven't the volume format type element.
> 
> Fortunately, 0 was treated as RAW file format before commit f772b3d9,
> so there was no problem. But now, 0 is treated as the type of none,
> qemu-img fails with "Unknown file format 'none'".
> 
> This patch fixes this issue by treating output block devices as RAW
> file format like for input block devices.
> 
> Signed-off-by: Atsushi Kumagai <kumagai-atsushi mxc nes nec co jp>
> 

ACK and pushed now.

Thank you.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]