[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5.2] virCaps: get rid of defaultConsoleTargetType callback



On Thu, Apr 04, 2013 at 02:16:09PM +0200, Peter Krempa wrote:
> This patch refactors various places to allow removing of the
> defaultConsoleTargetType callback from the virCaps structure.
> 
> A new console character device target type is introduced -
> VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_NONE - to mark that no type was
> specified in the XML. This type is at the end converted to the standard
> VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL. Other types that are
> different from this default have to be processed separately in the
> device post parse callback.
> ---
> I had some uncommited changes resulting from the rename of the structures when
> I was formatting v5.1. This version has the changes in.
> 
>  src/conf/capabilities.h          |   3 -
>  src/conf/domain_conf.c           | 269 +++++++++++++++++++++------------------
>  src/conf/domain_conf.h           |   3 +-
>  src/esx/esx_driver.c             |   8 --
>  src/libxl/libxl_conf.c           |  11 --
>  src/libxl/libxl_driver.c         |  19 +++
>  src/lxc/lxc_conf.c               |   8 --
>  src/lxc/lxc_domain.c             |  17 +++
>  src/openvz/openvz_conf.c         |  10 +-
>  src/openvz/openvz_driver.c       |  16 +++
>  src/parallels/parallels_driver.c |   7 -
>  src/phyp/phyp_driver.c           |   9 --
>  src/qemu/qemu_capabilities.c     |  13 --
>  src/qemu/qemu_domain.c           |   7 +
>  src/security/virt-aa-helper.c    |   7 -
>  src/test/test_driver.c           |   9 --
>  src/uml/uml_conf.c               |   9 --
>  src/uml/uml_driver.c             |  24 +++-
>  src/vbox/vbox_tmpl.c             |   9 --
>  src/vmware/vmware_conf.c         |   9 --
>  src/xen/xen_driver.c             |  28 +++-
>  src/xen/xen_driver.h             |   2 +
>  src/xen/xen_hypervisor.c         |  11 --
>  src/xenapi/xenapi_driver.c       |  28 ++--
>  tests/testutilslxc.c             |   9 --
>  tests/testutilsqemu.c            |  11 --
>  tests/testutilsxen.c             |  16 ---
>  tests/testutilsxen.h             |   2 -
>  tests/vmx2xmltest.c              |   7 -
>  tests/xmconfigtest.c             |   2 +-
>  tests/xml2sexprtest.c            |   3 +-
>  tests/xml2vmxtest.c              |   7 -
>  32 files changed, 278 insertions(+), 315 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]