[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Remove maximum cpu limit when setting processor count using the API



On Fri, Apr 05, 2013 at 12:11:31AM +0200, Peter Krempa wrote:
> When setting processor count for a domain using the API libvirt enforced
> a maximum processor count, while it isn't enforced when taking the XML path.
> 
> This patch removes the check to match the API.

Do you mean  s/API/XML/ here ?

I'm not sure whether removing this check is a good idea. Should we not
instead make the guest startup code also validate max CPU count when
generating the CLI args ?

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]