[libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

Peter Krempa pkrempa at redhat.com
Fri Apr 5 08:35:17 UTC 2013


On 04/05/13 09:37, Viktor Mihajlovski wrote:
> On 04/04/2013 09:50 PM, Peter Krempa wrote:
>>
>> I don't know if the realtek card works on the s390 qemu too, but if it
>> doesn't I don't mind changing it to virtio. In case it does work, we
>> need to consider if we aren't regressing here.
>>
>
> commit 539d73d intercepts this global defaulting but relies on the model
> being NULL. So your patch is indeed causing a regression. We can fix
> this before the next release though. No need for a V5.1.1 ;-)
>

That's the place I overlooked! :D okay, I will go with your fix in the 
connection callback and then we can get rid of the workarounds and have 
the management centralised.

Peter




More information about the libvir-list mailing list