[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [sandbox PATCH 11/15] Refactor Container class into Container and ServiceContainer Class.



On Wed, Apr 03, 2013 at 07:17:29PM -0400, Dan Walsh wrote:
> This way we can share common methods between the ServiceContainer and the
> InteractiveContainer (Patch to be added)
> ---
>  bin/virt-sandbox-service | 754 ++++++++++++++++++++++++-----------------------
>  1 file changed, 385 insertions(+), 369 deletions(-)

>      container.set_copy(args.copy)
> -    if args.network:
> -        for net in args.network:
> -            container.add_network(net)
> +    for net in args.network:
> +        container.add_network(net)

Hmm, I had the  'if args.network' because this would raise
an error about 'args.network' not existing, if no --network
args were provided on the command line. Are you sure this
still works when no  --network args are used ?


ACK if this issue is not a problem anymore, or if this chunk is
reverted.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]