[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [sandbox PATCH 12/15] Add support for InteractiveContainer



On Wed, Apr 03, 2013 at 07:17:30PM -0400, Dan Walsh wrote:
> First use case will be OpenShift
> 
> Differentiate on create based on whether one or more unit files specified
> (ServiceContainer), or a command is specified (Interactive Container).
> 
> Signed-off-by: Dan Walsh <dwalsh redhat com>
> ---
>  bin/virt-sandbox-service                    | 165 ++++++++++++++++++++--------
>  bin/virt-sandbox-service-bash-completion.sh |  16 +--
>  bin/virt-sandbox-service-create.pod         |  15 ++-
>  3 files changed, 136 insertions(+), 60 deletions(-)

> +    parser.add_argument("-n", "--network", dest="network",
> +                        action=SetNet, default=[],
> +                        help=_("Specify the network configuration"))


> -    parser.add_argument("-N", "--network", dest="network",
> -                        action=SetNet,
> -                        help=_("Specify the network configuration"))
> -
> -    image = parser.add_argument_group("Create On Disk Image File")

You're still changing -N into -n here.


ACK if you remove that change before pushing.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]