[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] qemu: Use correct default model on s390



On 04/05/13 13:02, Viktor Mihajlovski wrote:
On 04/05/2013 12:12 PM, Peter Krempa wrote:
@@ -688,9 +688,15 @@
qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,

      if (dev->type == VIR_DOMAIN_DEVICE_NET &&
          dev->data.net->type != VIR_DOMAIN_NET_TYPE_HOSTDEV) {
+        const char *model = NULL;
Now that I see what I wrote: the NULL assignment above is useless.
I assume you will need a third pair of eyes?


Oh, indeed :). My morning coffee hasn't kicked in at that time. We can even drop the model variable and duplicate the strdups to avoid the intermediate variable. V2 commencing.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]