[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/7] phyp: Prohibit fc_host adapter for phyp driver



On 05/04/13 23:20, John Ferlan wrote:
On 03/25/2013 12:43 PM, Osier Yang wrote:
It's possible to support fc_host adapter for phyp driver too, but
at this stage I'd like to not allow it when I'm not that clear
how it works.
---
  src/phyp/phyp_driver.c | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index 3a97364..a4e327e 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -2519,6 +2519,13 @@ phypBuildStoragePool(virConnectPtr conn, virStoragePoolDefPtr def)
      int exit_status = 0;
      virBuffer buf = VIR_BUFFER_INITIALIZER;
+ if (source.adapter.type !=
+        VIR_STORAGE_POOL_SOURCE_ADAPTER_TYPE_SCSI_HOST) {
So if it's == 0 (eg. DEFAULT) or not defined, then what happens here?
Can/will we get here in that scenario.

It can't, see the XML parsing, the type is either SCSI_HOST or FC_HOST after
the parsing.



+        virReportError(VIR_ERR_XML_ERROR, "%s",
+                       _("Only 'scsi_host' adapter is supported"));
+        goto cleanup;
+    }
+
      if (system_type == HMC)
          virBufferAsprintf(&buf, "viosvrcmd -m %s --id %d -c '",
                            managed_system, vios_id);

ACK with question/concern handled.

John

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]