[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function



On 04/05/2013 07:17 PM, Paolo Bonzini wrote:
Il 03/04/2013 05:37, Osier Yang ha scritto:

<code>readonly</code>
<dd>Indicates the device is readonly, only valid for SCSI device.
<span class="since">Since 1.0.5</span>.
</dd>

         <dt><code>boot</code></dt>
         <dd>Specifies that the device is bootable. The<code>order</code>
         attribute determines the order in which devices will be tried
during
diff --git a/docs/schemas/domaincommon.rng
b/docs/schemas/domaincommon.rng
index 8d7e6db..ccf0913 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -2911,6 +2911,11 @@
           <ref name="alias"/>
         </optional>
         <optional>
+<element name='readonly'>
+<empty/>
+</element>
+</optional>
+<optional>

Since the "readonly" is only valid for SCSI device. This patch should be
either
merged into 3/10, or rebased after it. It should be grouped in
"hostdevsubsysscsi",
to make sure it's only valid for SCSI device when doing RNG validation.

Note that sgio="filtered"/"unfiltered"/"default" can also be a valid
attribute.

Oh, I see.
Could we make it be done in another patch?

Cheng


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]