[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 04/16] Pull definition of structs out of vircgroup.c to vircgrouppriv.h



On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The definition of structs for cgroups are kept in vircgroup.c since
> they are intended to be private from users of the API. To enable
> effective testing, however, they need to be accessible. To address
> the latter issue, without compronmising the former, this introduces
> a new vircgrouppriv.h file to hold the struct definitions.
> 
> To prevent other files including this private header, it requires
> that __VIR_CGROUP_ALLOW_INCLUDE_PRIV_H__ be defined before inclusion
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/Makefile.am          |  2 +-
>  src/util/vircgroup.c     | 17 +++--------------
>  src/util/vircgrouppriv.h | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 50 insertions(+), 15 deletions(-)
>  create mode 100644 src/util/vircgrouppriv.h

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]