[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/8] cleanup: Use bool type instead of bitfield



On 11/04/13 09:52, Laine Stump wrote:
On 04/10/2013 12:32 PM, Osier Yang wrote:
This changes all the bitfield into bool type in domain_conf.h,
except domain->autostart, domain->persistent, and domain->updated,
as the public APIs like virDomainIsPersistent returns domain->persistent
as integer, they can be changed internally, but not that deserved.

Osier Yang (8):
   Cleanup: Change datatype of hostdev->managed to boolean
   Cleanup: Change datatype of origstate's members into boolean
   cleanup: Change datatype of hostdev->missing to boolean
   cleanup: Change datatype of auth->expires to boolean
   cleanup: Change datatype of disk->shared to boolean
   cleanup: Change datatype of disk->transient to boolean
   cleanup: Change datatype of disk->readonly to boolean
   cleanup: Change datatype of fs->readonly to boolean
For some reason these patches wouldn't apply to the head of master, but
they seem very straightforward and mechanical, and I think it's a useful
cleanup (if for no other reason that to avoid perpetuating the idea of
using bitfields).

I forgot I was on top of updating scsi-generic passthrough patches.


Assuming that you've run both make check and make syntax-check
successfully, ACK for the series.

Rebased, and make check/make syntax-check work fine, pushed.
Thanks.

Osier

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]