[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 13/16] Remove non-functional code for setting up non-root cgroups



On 10.04.2013 12:08, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virCgroupNewDriver method had a 'bool privileged' param.
> If a false value was ever passed in, it would simply not
> work, since non-root users don't have any privileges to create
> new cgroups. Just delete this broken code entirely and make
> the QEMU driver skip cgroup setup in non-privileged mode
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/lxc/lxc_cgroup.c   |  1 -
>  src/qemu/qemu_cgroup.c |  4 +++-
>  src/util/vircgroup.c   | 27 +++------------------------
>  src/util/vircgroup.h   |  1 -
>  tests/vircgrouptest.c  | 12 ++++++------
>  5 files changed, 12 insertions(+), 33 deletions(-)


ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]