[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: Report also domain name in error message when domain object wasn't found



On Fri, Apr 12, 2013 at 03:24:56PM +0200, Peter Krempa wrote:
> Report the errors as:
> Domain not found: no domain with matching uuid '41414141-4141-4141-4141-414141414141' (crashtest)
> instead of:
> Domain not found: no domain with matching uuid '41414141-4141-4141-4141-414141414141'
> ---
>  src/qemu/qemu_driver.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4051451..e3acdab 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -199,7 +199,8 @@ qemuDomObjFromDomain(virDomainPtr domain)
>      if (!vm) {
>          virUUIDFormat(domain->uuid, uuidstr);
>          virReportError(VIR_ERR_NO_DOMAIN,
> -                       _("no domain with matching uuid '%s'"), uuidstr);
> +                       _("no domain with matching uuid '%s' (%s)"),
> +                       uuidstr, domain->name);
>          return NULL;
>      }

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]