[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Check for QMP query-tpm-models



On Mon, Apr 15, 2013 at 04:55:00PM -0400, Stefan Berger wrote:
> On 04/15/2013 04:15 PM, Eric Blake wrote:
> >On 04/15/2013 01:49 PM, Stefan Berger wrote:
> >>Check for QMP query-tpm-models and set a capability flag. Do not use
> >>this QMP command if it is not supported.
> >>
> >>Signed-off-by: Stefan Berger <stefanb linux vnet ibm com>
> >>
> >>---
> >>  src/qemu/qemu_capabilities.c |    8 ++++++++
> >>  src/qemu/qemu_capabilities.h |    1 +
> >>  2 files changed, 9 insertions(+)
> >ACK.
> >
> Pushed.

NACK, please revert this. You should check "CommandNotFound" error
from the monitor command instead, as we do for other monitor commands
which can be missing.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]