[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Check for QMP query-tpm-models



On 04/16/2013 03:10 AM, Daniel P. Berrange wrote:
> On Mon, Apr 15, 2013 at 04:55:00PM -0400, Stefan Berger wrote:
>> On 04/15/2013 04:15 PM, Eric Blake wrote:
>>> On 04/15/2013 01:49 PM, Stefan Berger wrote:
>>>> Check for QMP query-tpm-models and set a capability flag. Do not use
>>>> this QMP command if it is not supported.
>>>>
>>>> Signed-off-by: Stefan Berger <stefanb linux vnet ibm com>
>>>>
>>>> ---
>>>>  src/qemu/qemu_capabilities.c |    8 ++++++++
>>>>  src/qemu/qemu_capabilities.h |    1 +
>>>>  2 files changed, 9 insertions(+)
>>> ACK.
>>>
>> Pushed.
> 
> NACK, please revert this. You should check "CommandNotFound" error
> from the monitor command instead, as we do for other monitor commands
> which can be missing.

My fault for suggesting and approving this method.  I forgot that we
have used qemu_monitor_json returning a special -2 on command not found
as a way to short-circuit needing to burn another capability bit; and
since capability bits become part of the XML contract across libvirtd
upgrades, fewer capabilities is a nicer goal for tasks like this.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]