[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/10] cleanup: Don't include libvirt/virterror.h

On 17/04/13 11:16, Eric Blake wrote:
On 04/16/2013 07:41 AM, Osier Yang wrote:
Which is already included in "internal.h", later patch will add
syntax-check to avoid it.
  src/remote/remote_driver.h | 2 --
  1 file changed, 2 deletions(-)

diff --git a/src/remote/remote_driver.h b/src/remote/remote_driver.h
index 7288381..bd907c0 100644
--- a/src/remote/remote_driver.h
+++ b/src/remote/remote_driver.h
@@ -24,8 +24,6 @@
  # define __VIR_REMOTE_INTERNAL_H__
-# include "libvirt/virterror.h"
  # include "configmake.h"
Except that none of the remaining includes pull in internal.h, so this
change would make the header not self-contained.  I'd be happier if you
did s#libvirt/virterror.h#internal.h# instead of deleting the line.

ACK with that change.

I pushed the 1/4 ~ 4/4. with this change; the shell script improved with your
suggestion in 1/4's commit log; 2/4 is rebased before 1/4. Thanks.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]