[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix typo in ocaml_libvirt_storage_vol_get_info



On 04/17/2013 04:23 AM, David Scott wrote:
> The info.capacity was being overwritten with the info.allocation.

If you will do:

git config format.subjectprefix 'ocaml PATCH'

then future patches from you will come with a mailing list header of:

[libvirt][ocaml PATCH] ...

to make it more obvious that this isn't against the main libvirt.git repo.

> 
> Signed-off-by: David Scott <dave scott eu citrix com>
> ---
>  libvirt/libvirt_c_oneoffs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt/libvirt_c_oneoffs.c b/libvirt/libvirt_c_oneoffs.c
> index 80e1c03..01985f5 100644
> --- a/libvirt/libvirt_c_oneoffs.c
> +++ b/libvirt/libvirt_c_oneoffs.c
> @@ -1418,7 +1418,7 @@ ocaml_libvirt_storage_vol_get_info (value volv)
>    rv = caml_alloc (3, 0);
>    Store_field (rv, 0, Val_int (info.type));
>    v = caml_copy_int64 (info.capacity); Store_field (rv, 1, v);
> -  v = caml_copy_int64 (info.allocation); Store_field (rv, 1, v);
> +  v = caml_copy_int64 (info.allocation); Store_field (rv, 2, v);

As to the patch itself, I'll let Rich handle that.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]