[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 08/11] conf: add PCI controllers

On 04/17/2013 05:12 PM, Eric Blake wrote:
> On 04/17/2013 01:00 PM, Ján Tomko wrote:
>> Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'.
>> ---
>>  docs/schemas/domaincommon.rng |  3 +++
>>  src/conf/domain_conf.c        | 21 ++++++++++++++++++++-
>>  src/conf/domain_conf.h        |  9 +++++++++
>>  3 files changed, 32 insertions(+), 1 deletion(-)
> ACK.

Spoke too soon - any time we touch domaincommon.rng, we should also
document the changes in docs/formatdomain.html.in.  I want to make sure
we have documentation before this series is pushed, even if it is easier
to add it on at the tail of the series rather than rebased into this
particular patch.  I'm also hoping that later in the series adds some
tests to prove the RNG grammar validates the new XML.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]