[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/2 RESEND] Add NVRAM device



On Thu, Apr 18, 2013 at 01:40:02PM +0800, Li Zhang wrote:
> From: Li Zhang <zhlcindy linux vnet ibm com>
> 
> For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device.
> Users are allowed to specify spapr-vio devices'address.
> But NVRAM is not supported in libvirt. So this patch is to
> add NVRAM device to allow users to specify its address.
> 
> In QEMU, NVRAM device's address is specified by
>  "-global spapr-nvram.reg=xxxxx".
> 
> In libvirt, XML file is defined as the following:
> 
>   <nvram>
>     <address type='spapr-vio' reg='0x3000'/>
>   </nvram>
> 
> Signed-off-by: Li Zhang <zhlcindy linux vnet ibm com>
> ---
>  v4 -> v3:
>   * Sperate NVRAM definition from qemu command line parser.
> 
>  v3 -> v2:
>   * Add NVRAM in domaincommon.rng and formatdomain.xml.in suggested by Daniel P.Berrange
>   * Add NVRAM test cases suggested by Daniel P.Berrange
>   * Remove nvram allocation when it is not specified suggested by Daniel P.Berrange
>   * Add several error reports suggested by Daniel P.Berrange
> 
>  v2 -> v1:
>   * Add NVRAM parameters parsing in qemuParseCommandLine
> 
>  docs/formatdomain.html.in     | 35 ++++++++++++++++++++
>  docs/schemas/domaincommon.rng | 10 ++++++
>  src/conf/domain_conf.c        | 76 +++++++++++++++++++++++++++++++++++++++++++
>  src/conf/domain_conf.h        | 10 ++++++
>  4 files changed, 131 insertions(+)

ACK

Danie
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]