[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Virsh command vol-rename



On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange <berrange redhat com> wrote:
> On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxiyou gmail com wrote:
>> From: Harry Wei <harryxiyou gmail com>
>>
>> Vol-rename is a convenience function, requiring when
>> one wanna rename a volume name.
>>
>> Signed-off-by: Harry Wei <harryxiyou gmail com>
>> ---
>>  tools/virsh-volume.c |  103 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 103 insertions(+)
>
> NACK copying & deleting volumes is totally not what people
> want from a "rename" command.
>

Hmmm..., maybe this is not direct for us. However, i am not sure
about what kind of "rename" command we need. Actually, i am
investigating what kind of "rename" we need. Let me give another
way.

Only change the name of volume and need not copying and
deleting volume. To back-end storage volume(Offline storage),
Libvirt just call relevant storage driver and the storage volume(with
a volume name) is created by back-end storage driver. If we wanna
change the volume name without copying and deleting, we may
need give hook function to let back-end driver to realize relevant
driver for rename stuffs.

Danpb, thanks for your comments very much.


--
Thanks
Harry Wei


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]