[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [sandbox PATCH 2/6] We should not turn on the sanbox shell by default.



On Thu, Apr 18, 2013 at 09:56:57AM -0400, dwalsh redhat com wrote:
> From: Dan Walsh <dwalsh redhat com>
> 
> We want to limit the number of processes which run within a container,
> especially for  openshift work loads.  Eventually we could add an
> option if someone wanted to run this shell.
> ---
>  bin/virt-sandbox-service | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service
> index d3dceea..6524a05 100755
> --- a/bin/virt-sandbox-service
> +++ b/bin/virt-sandbox-service
> @@ -258,7 +258,6 @@ class Container:
>  
>      def create(self):
>          self.connect()
> -        self.config.set_shell(True)
>          os.mkdir(self.dest)
>  
>      def connect(self):

NACK

This breaks the 'virt-sandbox-service connect' command. You should
only disable the shell for LXC based sandboxes. Then you need to
also make the 'connect' command use  'lxc-enter-namespace /bin/sh'
when given lxc:/// as the URI.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]