[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [sandbox PATCH 5/6] Add support for --uid, --gid, --username, --homedir for creation



On Thu, Apr 18, 2013 at 09:57:00AM -0400, dwalsh redhat com wrote:
> From: Dan Walsh <dwalsh redhat com>
> 
> Add missing options Itentity fields for new InteractiveContainer

Typo, I presume you mean 'identity' there, but even so the sentence
doesn't really make sense.

> ---
>  bin/virt-sandbox-service-bash-completion.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/bin/virt-sandbox-service-bash-completion.sh b/bin/virt-sandbox-service-bash-completion.sh
> index 874ee56..c672fdd 100755
> --- a/bin/virt-sandbox-service-bash-completion.sh
> +++ b/bin/virt-sandbox-service-bash-completion.sh
> @@ -1,6 +1,6 @@
>  # This file is part of libvirt-sandbox.
>  #
> -# Copyright 2012 Dan Walsh
> +# Copyright 2012-2013 Dan Walsh

Shouldn't this be copyright "Red Hat, Inc.", or do you realy intend
to claim personal copyright on it ?.

>  # systemd is free software; you can redistribute it and/or modify it
>  # under the terms of the GNU General Public License as published by
> @@ -55,7 +55,7 @@ _virt_sandbox_service () {
>      )
>      local -A OPTS=(
>          [ALL]='-h --help'
> -        [CREATE]='-u --unitfile -p --path -f --filetype -C --copy -i --imagesize -N --network -s --security'
> +        [CREATE]='-C --copy -f --filetype -G --gid  -i --imagesize --homedir -N --network -p --path -s --security -u --unitfile --username -U -uid'
>          [LIST]='-r --running'
>          [RELOAD]='-u --unitfile'
>          [EXECUTE]='-N --noseclabel'


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]