[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] Configure native vlan modes on Open vSwitch ports



On 04/18/2013 01:44 PM, james robson wrote:
> Hello,
> Has any one been able to review this yet? I realise that the 'Since
> 1.0.3' in the doc page is now out of date, but is the code itself
> acceptable?

I was hoping that someone with more knowledge of Open vSwitch and/or
vlan tagging/trunking/native mode would repond to the message (Kyle?)
but there was silence instead...


>
>
> diff --git a/tests/networkxml2xmlin/openvswitch-net.xml
> b/tests/networkxml2xmlin/openvswitch-net.xml
> index a3d82b1..93c49d5 100644
> --- a/tests/networkxml2xmlin/openvswitch-net.xml
> +++ b/tests/networkxml2xmlin/openvswitch-net.xml
> @@ -21,4 +21,13 @@
>        <parameters profileid='alice-profile'/>
>      </virtualport>
>    </portgroup>
> +  <portgroup name='tagged'>
> +    <vlan native_mode='tagged' native_tag='123'>
> +      <tag id='555'/>
> +      <tag id='444'/>
> +    </vlan>
> +    <virtualport>
> +      <parameters profileid='tagged-profile'/>
> +    </virtualport>
> +  </portgroup>

As brought up again in a separate conversation today, we prefer to use
camelCase rather than underscored in attribute and element names. So, if
we were to use the layout you're proposing, the attributes should be
called "nativeMode" and "nativeTag".

However, I'm wondering if there might be a better way to structure it.
What about this?


   <vlan trunk='yes'>
     <tag id='123' native='tagged|untagged'/> (or whatever values are
appropriate)
     <tag id='555'/>
     <tag id='444'/>
   </vlan>

Do I understand correctly that native mode is telling what to do with
packets that come in untagged, and that (using your nomenclature
"native_mode='yes' native_tag='123'" means "when an untagged packet come
in from this interface, it should be tagged as 123 before forwarding"?
And what happens when native_mode='yes' but there is no native_tag?
(that's what I was trying to describe with <tag id='123'
native='untagged'/>, but I don't even know if that makes sense, because
I don't know exactly what is the native vlan tag and what is done with
it :-)


Also, is it valid to have a native_mode/native_tag if trunk='no'? (right
now trunk is automatically set to 'yes' if there is more than one vlan tag)


>  </network>
> diff --git a/tests/networkxml2xmlout/openvswitch-net.xml
> b/tests/networkxml2xmlout/openvswitch-net.xml
> index a3d82b1..ab3d797 100644
> --- a/tests/networkxml2xmlout/openvswitch-net.xml
> +++ b/tests/networkxml2xmlout/openvswitch-net.xml
> @@ -21,4 +21,13 @@
>        <parameters profileid='alice-profile'/>
>      </virtualport>
>    </portgroup>
> +  <portgroup name='tagged'>
> +    <vlan trunk='yes' native_mode='tagged' native_tag='123'>
> +      <tag id='555'/>
> +      <tag id='444'/>
> +    </vlan>
> +    <virtualport>
> +      <parameters profileid='tagged-profile'/>
> +    </virtualport>
> +  </portgroup>
>  </network>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]