[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-designer PATCHv2 2/3] Add gvir_designer_domain_get_supported_devices()



On 18.04.2013 18:08, Christophe Fergeau wrote:
> This method gathers the list of devices supported by the hypervisor,
> and intersects this list with the list of devices supported
> by the OS, natively or using a driver (added with
> gvir_designer_domain_add_driver()). The lists can be filtered if
> needed.
> 
> This commit changes gvir_designer_domain_get_supported_disk_bus_types()
> to make use of that new helper. This will slightly change its behaviour
> as before this commit, it will consider any block devices from
> GVirDesignerDomain::os, while after this commit, it will only
> consider block devices from GVirDesignerDomain::os that are supported
> by GVirDesignerDomain::platform.
> 
> This will cause a change for example for OSes that only list
> virtio-block as a supported block device, such as Fedora as
> described in libosinfo v0.2.6-9-g7a8deb4
> ---
>  configure.ac                               |  2 +-
>  libvirt-designer/libvirt-designer-domain.c | 82 +++++++++++++++++++++++++++++-
>  2 files changed, 81 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index c999826..f03e36d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -10,7 +10,7 @@ AC_CANONICAL_HOST
>  
>  AM_SILENT_RULES([yes])
>  
> -LIBOSINFO_REQUIRED=0.2.3
> +LIBOSINFO_REQUIRED=0.2.6
>  LIBVIRT_GCONFIG_REQUIRED=0.0.9
>  LIBVIRT_GOBJECT_REQUIRED=0.1.3
>  GOBJECT_INTROSPECTION_REQUIRED=0.10.8

The requirements in README should be updated with this change as well.
And yes - they weren't updated previously :)

ACK if you update the README.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]