[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] audit: properly encode device path in cgroup audit



On 04/19/2013 12:02 PM, Laine Stump wrote:
> On 04/19/2013 01:36 PM, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=922186
>>
>> Commit d04916fa introduced a regression in audit quality - even
>> though the code was computing the proper escaped name for a
>> path, it wasn't feeding that escaped name on to the audit message.
>> As a result, /var/log/audit/audit.log would mention a field
>> path=/dev/hpet instead of the intended path="/dev/hpet", which
>> in turn caused ausearch to format the audit log as path=(null).

After some IRC discussion asking about the "path path" in the message, I
amended my commit message; this string is a substring fed into a larger

class=path path=...

of the audit message.

> 
> ACK.

Pushed now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]