[libvirt] [PATCH] qemu: Fix the wrong expression

Peter Krempa pkrempa at redhat.com
Mon Apr 22 10:56:38 UTC 2013


On 04/22/13 13:40, Osier Yang wrote:
> Wrong use of the parentheses causes "rc" always having a boolean value,
> either "1" or "0", and thus we can't get the detailed error message
> when it fails:
>
> Before (I only have 1 node):
> % virsh numatune f18 --nodeset 12
> error: Unable to change numa parameters
> error: unable to set numa tunable: Unknown error -1
>
> After:
> virsh numatune f18 --nodeset 12
> error: Unable to change numa parameters
> error: unable to set numa tunable: Invalid argument
> ---
>   src/qemu/qemu_driver.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

ACK.

Peter




More information about the libvir-list mailing list