[libvirt] [PATCH] Omitting braces with a single-line body

harryxiyou harryxiyou at gmail.com
Mon Apr 22 13:40:13 UTC 2013


On Mon, Apr 22, 2013 at 9:13 PM, Osier Yang <jyang at redhat.com> wrote:
> On 22/04/13 20:33, harryxiyou at gmail.com wrote:
>>
>> From: Harry Wei <harryxiyou at gmail.com>
>>
>> After i read libvirt/HACKING file, i find we should
>
>
> s/i/I/,

Actually, i wonder what 's/i/l/' means?

>
>
>> Omit braces with a single-line body. So this patch
>> fix this coding style problem for Sheepdog storage
>
>
> s/fix this/fixes the/,

The same problem as above.

>
>> backend driver.
>
>
> The commit log can be more compact:
>
> Prefer no braces for single line bodies.

Yup, i think so ;-)

>
>
[...]
>
> ACK

Thanks ;-)


--
Thanks
Harry Wei




More information about the libvir-list mailing list