[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rpc: message related sizes enlarged



On 22.04.2013 16:22, Viktor Mihajlovski wrote:
> From: Daniel Hansel <daniel hansel linux vnet ibm com>
> 
> We have seen an issue on s390x platform where domain XMLs larger than 1MB
> were used. The define command was finished successfully. The dumpxml command
> was not successful (i.e. could not encode message payload).
> 
> Enlarged message related sizes (e.g. maximum string size, message size, etc.)
> to handle larger system configurations used on s390x platform.
> 
> Signed-off-by: Daniel Hansel <daniel hansel linux vnet ibm com>
> Signed-off-by: Viktor Mihajlovski <mihajlov linux vnet ibm com>
> ---
>  src/remote/remote_protocol.x |    6 +++---
>  src/rpc/virnetprotocol.x     |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 

I am not hesitant to take this patch in. However, src/libvirt.c needs
update as well then. See eb635de1. We should tell users in documentation
that we have raised the RPC message limit.

Or even better - should the limit be turned into a config option so
system admins can decide on the most suitable value themselves? On one
hand, we need a bigger messages, obviously. But on the other hand,
libvirt is allocating a message for each connection so an evil user can
do a DOS attack by spoofing message length headers.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]