[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Omitting braces with a single-line body



On 04/22/2013 07:40 AM, harryxiyou wrote:
> On Mon, Apr 22, 2013 at 9:13 PM, Osier Yang <jyang redhat com> wrote:
>> On 22/04/13 20:33, harryxiyou gmail com wrote:
>>>
>>> From: Harry Wei <harryxiyou gmail com>
>>>
>>> After i read libvirt/HACKING file, i find we should
>>
>>
>> s/i/I/,
> 
> Actually, i wonder what 's/i/l/' means?

It's capital 'I', not lower case 'l'.  That's shorthand using sed syntax
for an in-place replacement you should perform on your text.  It means
you should have written:

After I read libvirt/HACKING file, I find we should

for that line, because in English, the pronoun 'I' is always capitalized.

>> ACK
> 
> Thanks ;-)

I'll go ahead and touch up the commit message as suggested, and push.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]