[libvirt] [PATCH] Use camelCase for XML attribute numQueues

Osier Yang jyang at redhat.com
Mon Apr 22 15:19:46 UTC 2013


On 22/04/13 22:43, Laine Stump wrote:
> On 04/22/2013 10:13 AM, Laine Stump wrote:
>> Of course in this case, we *could* avoid the camelCase vs underscore
>> entirely by just naming the attribute "queues" instead of numQueues or
>> num_queues (the fact that the attribute is a number makes it pretty
>> obvious that it is the "number of queues").
> And I notice that the patches for supporting multiple queues in
> interfaces uses <driver queues='n'/>, so consistency would vote in favor
> of using the same thing for <controller>.
>
I like the 'queues', as it avoids the question whether to use underscore
or camelCase.. :-)  So I don't mind changing the existing 'num_queues'
into 'queues'.

Osier




More information about the libvir-list mailing list