[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't require a block or file when looking for an alias.



On 04/24/2013 01:07 PM, Wido den Hollander wrote:
> Did this one get lost or forgotten?

Yep, so thanks for the ping.

> 
> Thanks,
> 
> Wido
> 
> On 04/05/2013 06:07 PM, Wido den Hollander wrote:
>> This for example prohibits you to use iotune for Ceph or Sheepdog
>> devices.
>>
>> Signed-off-by: Wido den Hollander <wido widodh nl>
>> ---
>>   src/qemu/qemu_driver.c |    4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index 552a81b..464d30a 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
>> @@ -13032,10 +13032,6 @@ qemuDiskPathToAlias(virDomainObjPtr vm, const
>> char *path, int *idx)
>>       if (idx)
>>           *idx = i;
>>
>> -    if (disk->type != VIR_DOMAIN_DISK_TYPE_BLOCK &&
>> -        disk->type != VIR_DOMAIN_DISK_TYPE_FILE)
>> -        goto cleanup;
>> -
>>       if (disk->src) {
>>           if (virAsprintf(&ret, "drive-%s", disk->info.alias) < 0) {
>>               virReportOOMError();

Looks reasonable to me.  ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]