[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/7] hypervisor api: implement RPC calls for virNodeDeviceDetachFlags



On 04/24/2013 01:26 PM, Laine Stump wrote:
> This requires a custom function for remoteNodeDeviceDetachFlags,
> because it is named *NodeDevice, but it goes through the hypervisor
> driver rather than nodedevice driver, and so it uses privateData
> instead of nodeDevicePrivateData. (It has to go through the hypervisor
> driver, because that is the driver that nows about the backend drivers

s/nows/knows/

> that will perform the pci device assignment).
> ---
>  src/remote/remote_driver.c   | 34 +++++++++++++++++++++++++++++++++-
>  src/remote/remote_protocol.x | 15 +++++++++++++--
>  src/remote_protocol-structs  |  6 ++++++
>  3 files changed, 52 insertions(+), 3 deletions(-)
> 

>  static int
> +remoteNodeDeviceDetachFlags(virNodeDevicePtr dev,
> +                            const char *driverName,
> +                            unsigned int flags)
> +{
> +    int rv = -1;
> +    remote_node_device_detach_flags_args args;
> +    /* This method is unusual in that it uses the HV driver, not the
> +     * devMon driver hence its use of privateData, instead of
> +     * nodeDevicePrivateData
> +     */

This comment is slightly out-of-date after commit 07a6b9aa (Dan's rename
to NodeDeviceDriver); but you are copying-and-pasting from an existing
problem.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]