[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Fix usb master startport parsing



On Thu, Apr 25, 2013 at 01:59:04PM +0200, Martin Kletzander wrote:
> When all usb controllers connected to the same bus have <master
> startport='x'/> specified, none of them have 'id=usb' assigned and
> thus qemu fails due to invalid masterport specification (we use 'usb'
> for that purpose).  Adding a check that at least one of the
> controllers is specified without <master startport='x'/> and in case
> this happens, error out due to invalid configuration.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
> v2:
>  - Don't fix user/app errors, just error out.
> ---
>  src/conf/domain_conf.c                              | 10 ++++++++++
>  .../qemuxml2argv-usb-ich9-no-companion.xml          | 21 +++++++++++++++++++++
>  tests/qemuxml2argvtest.c                            |  3 +++
>  3 files changed, 34 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-ich9-no-companion.xml

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]