[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] test: Add JSON test for query-tpm-types



On Thu, Apr 25, 2013 at 08:52:40AM -0400, Stefan Berger wrote:
> On 04/25/2013 07:06 AM, Daniel P. Berrange wrote:
> >On Mon, Apr 22, 2013 at 08:53:24AM -0400, Stefan Berger wrote:
> >>Add a test case for query-tpm-models QMP command.
> >>
> >>Signed-off-by: Stefan Berger <stefanb linux vnet ibm com>
> >>
> >>---
> >>  tests/qemumonitorjsontest.c |   55
> >>++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 55 insertions(+)
> >>
> >>Index: libvirt/tests/qemumonitorjsontest.c
> >>===================================================================
> >>--- libvirt.orig/tests/qemumonitorjsontest.c
> >>+++ libvirt/tests/qemumonitorjsontest.c
> >>@@ -25,6 +25,7 @@
> >>  #include "qemu/qemu_conf.h"
> >>  #include "virthread.h"
> >>  #include "virerror.h"
> >>+#include "virstring.h"
> >>
> >>
> >>  #define VIR_FROM_THIS VIR_FROM_NONE
> >>@@ -440,6 +441,59 @@ cleanup:
> >>
> >>
> >>  static int
> >>+testQemuMonitorJSONGetTPMModels(const void *data)
> >>+{
> >>+    virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data;
> >Don't cast  'void *'
> 
> I has to be casted due to the const. Adding const before
> virDomainXMLOptionPtr xmlopt doesn't help it. Also, it's c&p.

Ah, ok then.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]