[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Do proper escaping of cgroup resource partitions



On 04/26/2013 05:37 AM, Eric Blake wrote:
> On 04/26/2013 04:45 AM, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange" <berrange redhat com>
>>
>> If a user cgroup name begins with "cgroup.", "_" or with any of
>> the controllers from /proc/cgroups followed by a dot, then they
>> need to be prefixed with a single underscore. eg if there is
>> an object "cpu.service", then this would end up as "_cpu.service"
>> in the cgroup filesystem tree, however, "waldo.service" would
>> stay "waldo.service", at least as long as nobody comes up with
>> a cgroup controller called "waldo".
> 
> Do we also need to consider cgroup names beginning with leading '.'?

If so, that's something you need to coordinate with systemd again, so
I'm okay if you defer that decision to a followup patch.

> 
>>
> 
> I didn't closely inspect the test; but at least the fact that it is
> there gives us reassurance that the change is right.
> 

ACK, and series is okay for 1.0.5.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]