[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] S390: Add fake PCI root



On Fri, Apr 26, 2013 at 04:52:36PM +0200, Viktor Mihajlovski wrote:
> For the time being add a PCI root for s390 to avoid getting issues
> later on with PCI address checking. I don't want to unconditionally
> switch off PCI for s390.

NACK.

If the s390 machine does not currently have a PCI root, then we
should not be adding one to the XML.

We should be fixing the bug which prevents starting of VMs without
PCI, since this is a valid config - eg ARM guests will often not
have any PCI root.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]