[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: put usb cgroup setup in common function



On 04/29/2013 02:28 PM, Laine Stump wrote:
> The USB-specific cgroup setup had been inserted inline in
> qemuDomainAttachHostUsbDevice and qemuSetupCgroup, but now there is a
> common cgroup setup function called for all hostdevs, so it makes sens
> to put the usb-specific setup there and just rely on that function
> being called.
> 
> The one thing I'm uncertain of here (and a reason for not pushing
> until after release) is that previously hostdev->missing was checked
> only when starting a domain (and cgroup setup for the device skipped
> if missing was true), but with this consolidation, it is now checked
> in the case of hotplug as well. I don't know if this will have any
> practical effect (does it make sense to hotplug a "missing" usb
> device?)

Good question - and yeah, that uncertainty makes me also wonder if it
makes more sense to delay this patch until after 1.0.5 so we aren't
invalidating testing done on rc1.  On the other hand, the point of
hostdev->missing is to gracefully ignore devices that are called out in
XML but might not always exist; you are probably right that no one has
tried doing a hotplug while specifying that a missing device do nothing.
 I could live with this patch as part of 1.0.5 if it makes it into rc2
so that it gets a few more days of testing.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]