[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 37/37] viralloc.c: Do report OOM error in VIR_ALLOC and friends



On 04/29/2013 09:50 AM, Michal Privoznik wrote:
> For cases where caller doesn't want to repor an OOM error, he should use

s/repor/report

s/he should//

> VIR_ALLOC_QUIET or variants.
> ---
>  HACKING                     |   4 ++
>  docs/hacking.html.in        |   6 +++
>  po/POTFILES.in              |   1 +
>  python/libvirt-override.c   | 102 ++++++++++++++++++++++----------------------
>  src/esx/esx_vi.c            |   3 +-
>  src/util/viralloc.c         |  95 +++++++++++++++++++++++++++++++++++------
>  src/util/viralloc.h         |  54 ++++++++++++++++-------
>  src/util/virbuffer.c        |   8 ++--
>  src/util/virerror.c         |   4 +-
>  src/util/virthreadpthread.c |   2 +-
>  tests/networkxml2conftest.c |   2 +
>  tests/test_conf.c           |   2 +-
>  tests/xmconfigtest.c        |   2 +
>  13 files changed, 196 insertions(+), 89 deletions(-)
> 

>From a pure code motion viewpoint the changes seemed reasonable.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]