[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libvirt-guests: status: return non-zero when stopped



On 04/30/2013 05:55 AM, Ján Tomko wrote:
> Return 3 when the service is stopped, whether there
> are saved guests or not.

Please mention
http://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
in the commit message as justification.

> ---
>  tools/libvirt-guests.sh.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in
> index 4f2e203..261c488 100644
> --- a/tools/libvirt-guests.sh.in
> +++ b/tools/libvirt-guests.sh.in
> @@ -524,10 +524,11 @@ rh_status() {
>      else
>          if [ -f "$VAR_SUBSYS_LIBVIRT_GUESTS" ]; then
>              gettext "started"; echo
> +            RETVAL=0
>          else
>              gettext "stopped, with no saved guests"; echo
> +            RETVAL=3
>          fi
> -        RETVAL=0

ACK, and appropriate for 1.0.5.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]