[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 35/37] Introduce syntax-check rule to prefer VIR_STRDUP over strdup



On 04/30/2013 07:03 AM, John Ferlan wrote:
> On 04/29/2013 09:50 AM, Michal Privoznik wrote:
>> ---
>>  cfg.mk | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/cfg.mk b/cfg.mk
>> index d499ded..4c6d85c 100644
>> --- a/cfg.mk
>> +++ b/cfg.mk
>> @@ -383,6 +383,11 @@ sc_prohibit_asprintf:
>>  	halt='use virAsprintf, not as'printf				\
>>  	  $(_sc_search_regexp)
>>  
>> +sc_prohibit_strdup:
>> +	@prohibit='\<strn?dup\> *\('					\
>> +	halt='use VIR_STRUP, not strdup'				\
> 
> s/STRUP/STRDUP/
> 
> Do there need to be separate rules for STRDUP and STRNDUP?

Nah, one rule for both functions at once is good enough.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]