[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/4] Extra validation for the <sysinfo> section



Not necessary for 1.0.5, but figured I'd put it out there now.

https://bugzilla.redhat.com/show_bug.cgi?id=890494

The <sysinfo> section needs an extra uuid validation check.  The current
check compares the numerical sysinfo/system_uuid with the domain uuid;
however, it's possible that someone added extra hyphens into the sysinfo
uuid which results in the inability to start the domain (at least qemu).

The bug report indicates the 'date' field should at least be syntax checked
based on what's desribed in the SMBIOS spec.  From the spec:

"String number of the BIOS release date. The date string, if supplied, is
in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the string
is two digits, the year is assumed to be 19yy.

NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and later"

John Ferlan (4):
  docs: Fix syntax in sysinfo description
  docs: Update description of SMBIOS fields
  Validate the bios_date format for <sysinfo>
  Need better validation of <sysinfo> uuid

 docs/formatdomain.html.in | 51 ++++++++++++++++++++++++++++++++++++++---------
 src/conf/domain_conf.c    | 47 +++++++++++++++++++++++++++++++++++++++----
 2 files changed, 85 insertions(+), 13 deletions(-)

-- 
1.8.1.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]