[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] build: add configure option to disable gnulib tests



On 08/01/2013 07:10 AM, Peter Krempa wrote:
> On 08/01/13 00:48, Eric Blake wrote:
>> The gnulib testsuite is relatively stable - the only times it is
>> likely to have a test change from pass to fail is on a gnulib
>> submodule update or a major system change (such as moving from
>> Fedora 18 to 19, or other large change to libc).  While it is an
>> important test for end users on arbitrary machines (to make sure
>> that the portability glue works for their machine), it mostly
>> wastes time for development testing (as most developers aren't
>> making any of the major changes that would cause gnulib tests
>> to alter behavior).  Thus, it pays to make the tests optional
>> at configure time, defaulting to off for development, on for
>> tarballs, and where autobuilders can force the tests on.  It also
>> helps to make the configure choice have a runtime-override, by
>> using 'make check VIR_TEST_EXPENSIVE=1'.
>>

>> @@ -136,6 +148,7 @@
>>   <pre>
>>     ./qemuxml2xmltest
>>   </pre>
>> +
> 
> Stray newline addition? Or is the XSL transformation playing weird again?

Stray newline; will fix in v2.

> 
>>           <p>There is also a <code>./run</code> script at the top level,
>>             to make it easier to run programs that have not yet been
>>             installed, as well as to wrap invocations of various tests
> 
> When I configure libvirt with --enable-gnulib-tests then the
> VIR_TEST_EXPENSIVE doesn't get set and the expensive tests are not being
> run.

Yeah, I've decided to send a v2, that tries to be more like automake's
"V=0" or "V=1" overrides (the configure option sets a default, but the
default is overridable in both directions), and with the option named
closer to the override name.  But here's what I used for testing this v1:

./configure; make -C gnulib/tests check - from a tarball, lots of tests
run; from a git checkout, 0 tests run
./configure --enable-gnulib-tests; make -C gnulib/tests check - lots of
tests run whether from a tarball or git checkout
./configure --disable-gnulib-tests; make -C gnulib/tests check - no
tests run, whether from a tarball or git checkout
in all situations where no tests run, make -C gnulib/tests check
VIR_TEST_EXPENSIVE=1 - lots of tests run

> 
> Otherwise I really like this addition. I'll be sending some tests
> checking the  VIR_TEST_EXPENSIVE env variable today.

Then I'd better hurry up and post my v2 :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]