[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19.



On 08/01/2013 08:43 PM, Jincheng Miao wrote:
> 
> 
> ----- Original Message -----
>> From: "Eric Blake" <eblake redhat com>
>> To: "Jincheng Miao" <jmiao redhat com>
>> Cc: libvir-list redhat com
>> Sent: Friday, August 2, 2013 4:09:24 AM
>> Subject: Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19.
>>
>> This adds trailing whitespace, and fails 'make syntax-check'.  I'm also
>> surprised that you didn't hit failure with other clients of
>> libqemumonitortestutils.la, which were also listing libraries in the
>> wrong order.
>>
> 
> Sorry on my careless, I forget to 'make syntax-check'. And it caused by lacking '$(NULL)'.

No, it was caused by having a space after text and before the newline.

>> +qemumonitorjsontest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS)
> 
> here should be :
> +qemumonitorjsontest_LDADD = libqemumonitortestutils.la $(qemu_LDADDS) \
>                              $(NULL)

Use of $(NULL) helps multi-line comments be extendable in the future -
you only have to insert one line at the end, instead of modifying an
existing line to add a \ as well as your addition.  But when everything
fits on one line, there is no point to using $(NULL).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]