[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/9] qemu_command: Drop incorrect ATTRIBUTE_UNUSED annotation



On 08/01/2013 02:19 AM, Laine Stump wrote:
> On 07/31/2013 10:14 PM, Cole Robinson wrote:
>> ---
>>  src/qemu/qemu_command.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>> index aa3a2fd..d924110 100644
>> --- a/src/qemu/qemu_command.c
>> +++ b/src/qemu/qemu_command.c
>> @@ -1439,7 +1439,7 @@ struct _qemuDomainPCIAddressSet {
>>   * with the specified PCI address set.
>>   */
>>  static bool
>> -qemuPCIAddressValidate(qemuDomainPCIAddressSetPtr addrs ATTRIBUTE_UNUSED,
>> +qemuPCIAddressValidate(qemuDomainPCIAddressSetPtr addrs,
>>                         virDevicePCIAddressPtr addr,
>>                         qemuDomainPCIConnectFlags flags)
>>  {
> This is already included in a larger patch that refactors this function
> (as well as renaming it) which I'm about to post. I'd rather we pushed mine.

Here is the larger patch I was referring to:

https://www.redhat.com/archives/libvir-list/2013-August/msg00142.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]