[libvirt] [PATCH 0/7] Q35 support part 2

Sun Aug 4 02:11:14 UTC 2013

On 08/03/2013 10:06 PM, Doug Goldstein wrote:
> On Sat, Aug 3, 2013 at 8:48 PM, Laine Stump <laine at laine.org> wrote:
>> On 08/03/2013 09:36 PM, Doug Goldstein wrote:
>>> On Sat, Aug 3, 2013 at 6:28 PM, Laine Stump <laine at laine.org> wrote:
>>>> ...and here is the result of applying all 10 patches of this 7 patch
>>>> series, and starting up a domain using the config file attached to the
>>>> end of this message:
>>>>
>>>> # lspci
>>>> 00:00.0 Host bridge: Intel Corporation 82G33/G31/P35/P31 Express DRAM
>>>> Controller
>>>> 00:01.0 VGA compatible controller: Red Hat, Inc. Device 0100 (rev 04)
>>>> 00:02.0 PCI bridge: Red Hat, Inc. Device 0001
>>>> 00:1f.0 ISA bridge: Intel Corporation 82801IB (ICH9) LPC Interface
>>>> Controller (rev 02)
>>>> 00:1f.2 SATA controller: Intel Corporation 82801IR/IO/IH (ICH9R/DO/DH) 6
>>>> port SATA AHCI Controller (rev 02)
>>>> 00:1f.3 SMBus: Intel Corporation 82801I (ICH9 Family) SMBus Controller
>>>> (rev 02)
>>>> 01:01.0 PCI bridge: Red Hat, Inc. Device 0001
>>>> 02:01.0 Ethernet controller: Red Hat, Inc Virtio network device
>>>> 02:02.0 Ethernet controller: Red Hat, Inc Virtio network device
>>>> 02:03.0 Multimedia audio controller: Intel Corporation 82801AA AC'97
>>>> Audio Controller (rev 01)
>>>> 02:04.0 Communication controller: Red Hat, Inc Virtio console
>>>> 02:05.0 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
>>>> Controller #1 (rev 03)
>>>> 02:05.1 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
>>>> Controller #2 (rev 03)
>>>> 02:05.2 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
>>>> Controller #3 (rev 03)
>>>> 02:05.7 USB Controller: Intel Corporation 82801I (ICH9 Family) USB2 EHCI
>>>> Controller #1 (rev 03)
>>>> 02:06.0 SCSI storage controller: Red Hat, Inc Virtio block device
>>>> 02:07.0 Unclassified device [00ff]: Red Hat, Inc Virtio memory balloon
>>>> 02:08.0 SATA controller: Intel Corporation 82801IR/IO/IH (ICH9R/DO/DH) 6
>>>> port SATA AHCI Controller (rev 02)
>>>>
>>>> You'll notice that everything except the VGA, the implicit devices are
>>>>
>>>> Yay!
>>>>
>>>> Now if virt-manager just provided a way to change the machinetype of
>>>> guests as they were being created... (does virt-manager explicitly
>>>> specify USB controllers? Currently the Q35 doesn't automatically create
>>>> a USB controller (see the patch comments)
>>>>
>>>> =========
>>>> <domain type='kvm'>
>>>>   <name>F15-q35</name>
>>>>   <memory unit='KiB'>1048576</memory>
>>>>   <currentMemory unit='KiB'>1048576</currentMemory>
>>>>   <os>
>>>>     <type arch='x86_64' machine='pc-q35-1.5'>hvm</type>
>>>>     <boot dev='hd'/>
>>>>     <bootmenu enable='yes'/>
>>>>   </os>
>>>>   <features>
>>>>     <acpi/>
>>>>     <apic/>
>>>>     <pae/>
>>>>   </features>
>>>>   <clock offset='utc'/>
>>>>   <devices>
>>>>     <emulator>/usr/bin/qemu-kvm</emulator>
>>>>     <disk type='file' device='disk'>
>>>>       <driver name='qemu' type='raw'/>
>>>>       <source file='/var/lib/libvirt/images/F15.img'/>
>>>>       <target dev='vda' bus='virtio'/>
>>>>     </disk>
>>>>     <disk type='file' device='cdrom'>
>>>>       <driver name='qemu' type='raw'/>
>>>>       <source file='/home/laine/example.iso'/>
>>>>       <target dev='hdc' bus='sata'/>
>>>>       <readonly/>
>>>>       <address type='drive' controller='0' bus='0' target='0' unit='0'/>
>>>>     </disk>
>>>>     <controller type='virtio-serial' index='0'/>
>>>>     <controller type='usb' index='0' model='ich9-ehci1'/>
>>>>     <controller type='usb' index='0' model='ich9-uhci1'>
>>>>       <master startport='0'/>
>>>>       <address type='pci' domain='0x0000' bus='0x02' slot='0x05'
>>>> function='0x0' multifunction='on'/>
>>>>     </controller>
>>>>     <controller type='usb' index='0' model='ich9-uhci2'>
>>>>       <master startport='2'/>
>>>>       <address type='pci' domain='0x0000' bus='0x02' slot='0x05'
>>>> function='0x1'/>
>>>>     </controller>
>>>>     <controller type='usb' index='0' model='ich9-uhci3'>
>>>>       <master startport='4'/>
>>>>       <address type='pci' domain='0x0000' bus='0x02' slot='0x05'
>>>> function='0x2'/>
>>>>     </controller>
>>>>     <controller type='sata' index='0'/>
>>>>     <controller type='sata' index='1'/>
>>>>     <controller type='pci' index='0' model='pcie-root'/>
>>>>     <interface type='network'>
>>>>       <source network='ipv6'/>
>>>>       <model type='virtio'/>
>>>>     </interface>
>>>>     <interface type='network'>
>>>>       <source network='isolated'/>
>>>>       <model type='virtio'/>
>>>>     </interface>
>>>>     <serial type='pty'>
>>>>       <target port='0'/>
>>>>     </serial>
>>>>     <console type='pty'>
>>>>       <target type='serial' port='0'/>
>>>>     </console>
>>>>     <input type='mouse' bus='ps2'/>
>>>>     <graphics type='vnc' port='-1' autoport='yes'/>
>>>>     <sound model='ac97'/>
>>>>     <video>
>>>>       <model type='qxl' ram='65536' vram='9216' heads='1'/>
>>>>     </video>
>>>>     <memballoon model='virtio'/>
>>>>   </devices>
>>>> </domain>
>>>>
>>>> --
>>>> libvir-list mailing list
>>>> libvir-list at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/libvir-list
>>> Excellent thanks for providing a reference example. I've been trying
>>> to review all your patches and work through testing bits and pieces
>>> myself. I should have probably spoke up on the ML rather than
>>> remaining silent. I'll finish up testing it tonight and ACK a handful
>>> shortly.
>>>
>> I have made some small changes to some of the other patches in the
>> meantime. If you're serious to the point of actually testing them out, I
>> should repost the ones I haven't yet pushed (only the first three).
>> Coming up momentarily...
> Yeah please repost. Until you mentioned the seabios stuff in your last
> e-mail I had been debugging that. 

That took me a while to figure out too (and I was getting really worried
until I did). I'm just glad that Alex Williamson had previously told me
that qemu wasn't strict about the "can't plug a PCI device into a PCIe
slot" rule.

> I've got a CentOS 6.4 VM I'm trying
> to get up under Q35 on qemu-1.5.2 + libvirt master + your patch set as
> part of my review.

Cool! The more real world testing the better! Thanks for taking the time
to do that. (My testing has been with an existing Fedora 15 guest that
was hanging around. Not sure why I picked that one; maybe because it was
the most disposable item on the list :-)