[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] : [Bug 993411] Compilation fails on lxc/lxc_monitor_protocol.c 31: undefined reference to xdr_uinit64_t



On 08/06/2013 03:27 AM, Daniel P. Berrange wrote:
> On Mon, Aug 05, 2013 at 04:19:54PM -0500, Gerald Palmer wrote:
>>  
>> suggested patch for compilation issue.
>> --- lxc_monitor_protocol.h      2013-08-05 20:22:23.963000000 +0000
>> +++ libvirt-1.1.1/src/lxc/lxc_monitor_protocol.h        2013-08-05 20:22:46.226000000 +0000

This is a generated file.  Changes made here will be lost when the file
is regenerated.  We need to move the change into the source, which is
lxc/lxc_monitor_protocol.x.

>> @@ -5,6 +5,8 @@
>>
>>  #ifndef _LXC_MONITOR_PROTOCOL_H_RPCGEN
>>  #define _LXC_MONITOR_PROTOCOL_H_RPCGEN
>> +# define xdr_uint64_t xdr_u_int64_t
>> +
> 
> What platform are you compiling on ?

And should we fix this for ALL the protocols at once?  It looks like
this snippet from src/remote/remote_protocol.x is more likely to be
correct; but if that's the case, we should hoist it into
src/rpc/genprotocol.pl to happen for ALL .x files rather than copying
and pasting it everywhere.

/* cygwin's xdr implementation defines xdr_u_int64_t instead of xdr_uint64_t
 * and lacks IXDR_PUT_INT32 and IXDR_GET_INT32
 */
%#ifdef HAVE_XDR_U_INT64_T
%# define xdr_uint64_t xdr_u_int64_t
%#endif
%#ifndef IXDR_PUT_INT32
%# define IXDR_PUT_INT32 IXDR_PUT_LONG
%#endif
%#ifndef IXDR_GET_INT32
%# define IXDR_GET_INT32 IXDR_GET_LONG
%#endif
%#ifndef IXDR_PUT_U_INT32
%# define IXDR_PUT_U_INT32 IXDR_PUT_U_LONG
%#endif
%#ifndef IXDR_GET_U_INT32
%# define IXDR_GET_U_INT32 IXDR_GET_U_LONG
%#endif

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]