[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Reverse logic allowing partial DHCP host XML



On 08/02/2013 12:10 PM, Laine Stump wrote:
> On 07/31/2013 07:41 AM, Ján Tomko wrote:
>> Before, missing attributes were only OK when adding entries;
>> modification and deletion required all of them.
>>
>> Now, only deletion works with missing attributes, as long as
>> the host is uniquely identified.
>> ---
>>  src/conf/network_conf.c | 21 +++++----------------
>>  1 file changed, 5 insertions(+), 16 deletions(-)
>>
>> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
>> index a0b543c..16bdb45 100644
>> --- a/src/conf/network_conf.c
>> +++ b/src/conf/network_conf.c
>> @@ -3297,6 +3297,7 @@ virNetworkDefUpdateIPDHCPHost(virNetworkDefPtr def,
>>      int ret = -1;
>>      virNetworkIpDefPtr ipdef = virNetworkIpDefByIndex(def, parentIndex);
>>      virNetworkDHCPHostDef host;
>> +    bool isDelete = (command == VIR_NETWORK_UPDATE_COMMAND_DELETE);
> 
> 
> ACK, but change the name of this bool to partialOkay to match its
> meaning and be consistent with what it's being named in
> virNetworkDHCPHostDefParseXML.
> 

Renamed and pushed.

Thanks!

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]