[libvirt] [PATCH] virthread: include config.h in the header file

Paul Moore pmoore at redhat.com
Wed Aug 7 15:11:20 UTC 2013


The virthread.h header file includes platform specific header files
that help define the thread implementation, see code snippet below.

  # ifdef WIN32
  #  include "virthreadwin32.h"
  # elif defined HAVE_PTHREAD_MUTEXATTR_INIT
  #  include "virthreadpthread.h"
  # else
  #  error "Either pthreads or Win32 threads are required"
  # endif

Unfortunately, virthread.h does not include config.h so every source
file which includes virthread.h must also include config.h, regardless
of if the source file directly needs definitions in config.h.  This
patch adds config.h to virthread.h in an effort to help simplify
things.

Signed-off-by: Paul Moore <pmoore at redhat.com>
---
 src/util/virthread.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/util/virthread.h b/src/util/virthread.h
index 84d3bdc..091cdd0 100644
--- a/src/util/virthread.h
+++ b/src/util/virthread.h
@@ -22,6 +22,8 @@
 #ifndef __THREADS_H_
 # define __THREADS_H_
 
+#include <config.h>
+
 # include "internal.h"
 # include "virerror.h"
 




More information about the libvir-list mailing list